From 6ba69f4610a07cea79eebc6e2fc50b023d9ae5e8 Mon Sep 17 00:00:00 2001 From: Hermes Date: Mon, 11 May 2026 15:16:59 +0000 Subject: [PATCH] review fixes: in-suite, version bump, default children method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes from subagent review: - render-tests.lisp: added (in-suite box-suite) — tests were registered to default suite, never executed by runner - dirty-tests.lisp: same fix - cl-tui.asd: version 0.2.0 → 0.3.0 - render.lisp: component-children default method (c t) nil for protocol completeness (component-parent already had this) --- cl-tui.asd | 2 +- src/components/dirty-tests.lisp | 1 + src/components/render-tests.lisp | 1 + src/components/render.lisp | 3 +-- 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/cl-tui.asd b/cl-tui.asd index 2bc9f16..3ccc036 100644 --- a/cl-tui.asd +++ b/cl-tui.asd @@ -2,7 +2,7 @@ (asdf:defsystem :cl-tui :description "Reusable Common Lisp Terminal UI Framework" :author "Amr Gharbeia" - :version "0.2.0" + :version "0.3.0" :license "TBD" :depends-on (:fiveam) :components diff --git a/src/components/dirty-tests.lisp b/src/components/dirty-tests.lisp index c6a4d56..89b6bac 100644 --- a/src/components/dirty-tests.lisp +++ b/src/components/dirty-tests.lisp @@ -1,5 +1,6 @@ ;; Dirty tracking tests are in box-tests.lisp (same test suite) (in-package :cl-tui-box-test) +(in-suite box-suite) (test dirty-mixin-default-is-dirty "A dirty-mixin starts as dirty" diff --git a/src/components/render-tests.lisp b/src/components/render-tests.lisp index 52779ac..f0f552c 100644 --- a/src/components/render-tests.lisp +++ b/src/components/render-tests.lisp @@ -1,4 +1,5 @@ (in-package :cl-tui-box-test) +(in-suite box-suite) (defun make-capturing-backend () (let* ((s (make-string-output-stream)) diff --git a/src/components/render.lisp b/src/components/render.lisp index d5aadc2..85b17e7 100644 --- a/src/components/render.lisp +++ b/src/components/render.lisp @@ -9,8 +9,7 @@ (defgeneric component-children (component) (:documentation "Return the children of COMPONENT, or nil.") - (:method ((bx box)) nil) - (:method ((tx text)) nil)) + (:method ((c t)) nil)) (defgeneric component-parent (component) (:documentation "Return the parent of COMPONENT, or nil.")