v0.8.2: cleanup + prose + structure + decomposition + budget + errors
Phase 1 — dedup + hardening (~9 items): - Remove duplicate *skill-registry* defvar from core-skills - Merge *backend-registry* into *probabilistic-backends*, delete backend-register - Remove inject-stimulus alias, standardize on stimulus-inject - Add pre-eval sandbox (skill-source-scan) blocks restricted symbols before eval - Remove dead plist-get function; remove duplicate json-alist-to-plist export - Fix read-framed-message whitespace DoS (4096-iteration max) - Add *read-eval* nil to dispatcher-approvals-process read-from-string (RCE) - Add test-op to ASDF; update .asd version 0.4.3→0.7.2 Phase 2 — prose + contracts + reorder: - Split ROADMAP: 2623→1089 lines (TODO only), CHANGELOG: 260→1528 lines (full DONE history, 14 versions reverse chron) - Add Contracts + Overview to 6 channel files + embedding-native + programming-standards + symbolic-scope - Reorder 28 .org files: Contract → Test Suite → Implementation (TDD order) - Add 7-phase inline prose to think() in core-reason - Expand USER_MANUAL: 183→461 lines (10 new sections) Phase 3 — decomposition + export organization: - Decompose think() into think-assemble-prompt, think-call-llm, think-parse-response orchestrator - Organize 188 exports into 16 grouped sections by module Phase 4 — budget enforcement + error protocol: - Per-session budget enforcement (SESSION_BUDGET_USD env var, budget-exhausted-p, guard in think-call-llm) - Error condition hierarchy (6 conditions: pipeline-error, llm-error, gate-error, budget-error, protocol-error) - Restarts in loop-process: skip-signal, use-fallback, abort-pipeline
This commit is contained in:
@@ -14,6 +14,73 @@ The core provides the mechanism (=memory-object-scope=, =context-query= with
|
||||
scope parameter). This skill provides the policy — what to focus on, what
|
||||
scope means for each project, and how the stack is managed.
|
||||
|
||||
** Contract
|
||||
|
||||
1. (push-context &key project base-path scope): pushes a context plist
|
||||
onto ~*context-stack*~. Blocks if depth exceeds ~*context-max-depth*~.
|
||||
2. (pop-context): pops and returns the top context. If the stack would
|
||||
become empty, inserts a default memex-wide context instead.
|
||||
3. (current-context): returns the top-of-stack context plist.
|
||||
4. (current-scope): returns the ~:scope~ keyword from the current context.
|
||||
5. (current-project): returns the ~:project~ name from the current context.
|
||||
6. (current-base-path): returns the ~:base-path~ from the current context.
|
||||
7. (context-stack-depth): returns the number of contexts on the stack.
|
||||
8. (focus-project name base-path): pushes a new context for the named
|
||||
project. Sets ~*scope-resolver*~ to return ~:project~.
|
||||
9. (focus-session): pushes an ephemeral context for the current session.
|
||||
10. (focus-memex): pushes a global memex-wide context.
|
||||
11. (unfocus): pops one level from the context stack.
|
||||
12. (resolve-path path): resolves a path relative to the current base-path.
|
||||
13. (context-scoped-query &key tag todo-state type): queries memory filtered
|
||||
by the current context's scope.
|
||||
14. (context-save): persists the context stack to disk.
|
||||
15. (context-load): restores the context stack from disk on startup.
|
||||
|
||||
* Test Suite
|
||||
#+begin_src lisp
|
||||
(eval-when (:compile-toplevel :load-toplevel :execute)
|
||||
(ql:quickload :fiveam :silent t))
|
||||
|
||||
(defpackage :passepartout-context-tests
|
||||
(:use :cl :passepartout)
|
||||
(:export #:context-suite))
|
||||
|
||||
(in-package :passepartout-context-tests)
|
||||
|
||||
(fiveam:def-suite context-suite :description "Context manager verification")
|
||||
(fiveam:in-suite context-suite)
|
||||
|
||||
(fiveam:test test-push-pop-context
|
||||
"Contract 1-2: push-context and pop-context maintain stack order."
|
||||
(let* ((pkg (find-package "PASSEPARTOUT.SKILLS.SYSTEM-CONTEXT-MANAGER"))
|
||||
(stack-var (and pkg (find-symbol "*CONTEXT-STACK*" pkg)))
|
||||
(pf-var (and pkg (find-symbol "*CONTEXT-PERSISTENCE-FILE*" pkg))))
|
||||
(when stack-var
|
||||
(setf (symbol-value stack-var) nil)
|
||||
(push-context :project "testapp" :base-path "/tmp" :scope :project)
|
||||
(fiveam:is (= 1 (length (symbol-value stack-var))))
|
||||
(fiveam:is (string= "testapp" (getf (car (symbol-value stack-var)) :project)))
|
||||
(pop-context)
|
||||
(fiveam:is (null (symbol-value stack-var))))))
|
||||
|
||||
(fiveam:test test-context-save-load
|
||||
"Contract 3-4: context-save and context-load round-trip."
|
||||
(let* ((pkg (find-package "PASSEPARTOUT.SKILLS.SYSTEM-CONTEXT-MANAGER"))
|
||||
(stack-var (and pkg (find-symbol "*CONTEXT-STACK*" pkg)))
|
||||
(pf-var (and pkg (find-symbol "*CONTEXT-PERSISTENCE-FILE*" pkg))))
|
||||
(when (and stack-var pf-var)
|
||||
(let* ((tmpfile (merge-pathnames "test-context.lisp" (uiop:temporary-directory))))
|
||||
(setf (symbol-value pf-var) tmpfile)
|
||||
(setf (symbol-value stack-var) (list '(:project "test" :base-path "/tmp" :scope :project)))
|
||||
(context-save)
|
||||
(fiveam:is (probe-file tmpfile))
|
||||
(setf (symbol-value stack-var) nil)
|
||||
(context-load)
|
||||
(fiveam:is (= 1 (length (symbol-value stack-var))))
|
||||
(fiveam:is (string= "test" (getf (car (symbol-value stack-var)) :project)))
|
||||
(ignore-errors (delete-file tmpfile))))))
|
||||
#+end_src
|
||||
|
||||
* Implementation
|
||||
|
||||
** Context Stack
|
||||
@@ -297,47 +364,3 @@ Also restores any previously saved context stack.
|
||||
3. (context-save): serializes ~*context-stack*~ to the persistence file.
|
||||
4. (context-load): restores ~*context-stack*~ from persistence file on boot.
|
||||
|
||||
* Test Suite
|
||||
#+begin_src lisp
|
||||
(eval-when (:compile-toplevel :load-toplevel :execute)
|
||||
(ql:quickload :fiveam :silent t))
|
||||
|
||||
(defpackage :passepartout-context-tests
|
||||
(:use :cl :passepartout)
|
||||
(:export #:context-suite))
|
||||
|
||||
(in-package :passepartout-context-tests)
|
||||
|
||||
(fiveam:def-suite context-suite :description "Context manager verification")
|
||||
(fiveam:in-suite context-suite)
|
||||
|
||||
(fiveam:test test-push-pop-context
|
||||
"Contract 1-2: push-context and pop-context maintain stack order."
|
||||
(let* ((pkg (find-package "PASSEPARTOUT.SKILLS.SYSTEM-CONTEXT-MANAGER"))
|
||||
(stack-var (and pkg (find-symbol "*CONTEXT-STACK*" pkg)))
|
||||
(pf-var (and pkg (find-symbol "*CONTEXT-PERSISTENCE-FILE*" pkg))))
|
||||
(when stack-var
|
||||
(setf (symbol-value stack-var) nil)
|
||||
(push-context :project "testapp" :base-path "/tmp" :scope :project)
|
||||
(fiveam:is (= 1 (length (symbol-value stack-var))))
|
||||
(fiveam:is (string= "testapp" (getf (car (symbol-value stack-var)) :project)))
|
||||
(pop-context)
|
||||
(fiveam:is (null (symbol-value stack-var))))))
|
||||
|
||||
(fiveam:test test-context-save-load
|
||||
"Contract 3-4: context-save and context-load round-trip."
|
||||
(let* ((pkg (find-package "PASSEPARTOUT.SKILLS.SYSTEM-CONTEXT-MANAGER"))
|
||||
(stack-var (and pkg (find-symbol "*CONTEXT-STACK*" pkg)))
|
||||
(pf-var (and pkg (find-symbol "*CONTEXT-PERSISTENCE-FILE*" pkg))))
|
||||
(when (and stack-var pf-var)
|
||||
(let* ((tmpfile (merge-pathnames "test-context.lisp" (uiop:temporary-directory))))
|
||||
(setf (symbol-value pf-var) tmpfile)
|
||||
(setf (symbol-value stack-var) (list '(:project "test" :base-path "/tmp" :scope :project)))
|
||||
(context-save)
|
||||
(fiveam:is (probe-file tmpfile))
|
||||
(setf (symbol-value stack-var) nil)
|
||||
(context-load)
|
||||
(fiveam:is (= 1 (length (symbol-value stack-var))))
|
||||
(fiveam:is (string= "test" (getf (car (symbol-value stack-var)) :project)))
|
||||
(ignore-errors (delete-file tmpfile))))))
|
||||
#+end_src
|
||||
Reference in New Issue
Block a user