CHORE: Prepare for Signal Gateway implementation

2026-04-11 15:48:22 -04:00
parent 8ba3532067
commit 975a11da79
8 changed files with 192 additions and 39 deletions
--- a/skills/org-skill-chat.org
+++ b/skills/org-skill-chat.org
@@ -108,7 +108,7 @@ REQUIRED FORMATS:
 #+end_src

 * Registration
-#+begin_src lisp
+#+begin_src lisp :tangle ../src/chat-logic.lisp
 (defskill :skill-chat
  :priority 100
  :trigger #'trigger-skill-chat
--- a/skills/org-skill-gateway-telegram.org
+++ b/skills/org-skill-gateway-telegram.org
@@ -42,13 +42,32 @@ The gateway operates as an autonomous background service. It uses `dexador` for
 (in-package :org-agent)
 #+end_src

-** State & Config
+** State: Update Tracking
+Tracks the last processed message ID to prevent duplicates.
+
 #+begin_src lisp :tangle ../src/gateway-telegram.lisp
 (defvar *telegram-last-update-id* 0)
+#+end_src
+
+** State: Polling Thread
+Reference to the background thread responsible for message reception.
+
+#+begin_src lisp :tangle ../src/gateway-telegram.lisp
 (defvar *telegram-polling-thread* nil)
+#+end_src
+
+** State: Authorized Chats
+Whitelist of chat IDs permitted to interact with the agent.
+
+#+begin_src lisp :tangle ../src/gateway-telegram.lisp
 (defvar *telegram-authorized-chats* nil 
  "List of chat IDs allowed to interact with the bot. Hydrated from environment.")
+#+end_src

+** Token Retrieval
+Fetches the Bot API token from the secure vault.
+
+#+begin_src lisp :tangle ../src/gateway-telegram.lisp
 (defun get-telegram-token () (vault-get-secret :telegram))
 #+end_src

@@ -102,7 +121,9 @@ The gateway operates as an autonomous background service. It uses `dexador` for
        (error (c) (kernel-log "TELEGRAM POLL ERROR: ~a" c))))))
 #+end_src

-** Background Polling Loop
+** Start Polling
+Initializes the Telegram background thread.
+
 #+begin_src lisp :tangle ../src/gateway-telegram.lisp
 (defun start-telegram-gateway ()
  "Initializes the Telegram background thread."
@@ -115,24 +136,39 @@ The gateway operates as an autonomous background service. It uses `dexador` for
               (sleep 3)))
           :name "org-agent-telegram-gateway"))
    (kernel-log "TELEGRAM: Gateway polling active.")))
+#+end_src

+** Stop Polling
+Gracefully terminates the background thread.
+
+#+begin_src lisp :tangle ../src/gateway-telegram.lisp
 (defun stop-telegram-gateway ()
  (when (and *telegram-polling-thread* (bt:thread-alive-p *telegram-polling-thread*))
    (bt:destroy-thread *telegram-polling-thread*)
    (setf *telegram-polling-thread* nil)))
 #+end_src

-** Skill Definition & Registration
+** Registration: Actuator
+Register the Telegram channel as a physical actuator.
+
 #+begin_src lisp :tangle ../src/gateway-telegram.lisp
-(progn
-  (register-actuator :telegram #'execute-telegram-action)
-  
-  (defskill :skill-gateway-telegram
-    :priority 150
-    :trigger (lambda (ctx) (declare (ignore ctx)) nil) ;; Passive, handles its own loop
-    :neuro nil
-    :symbolic (lambda (action ctx) (declare (ignore ctx)) action))
-  
-  ;; Initialize the background polling loop
-  (start-telegram-gateway))
+(register-actuator :telegram #'execute-telegram-action)
+#+end_src
+
+** Registration: Skill
+Define the passive skill entry for the gateway.
+
+#+begin_src lisp :tangle ../src/gateway-telegram.lisp
+(defskill :skill-gateway-telegram
+  :priority 150
+  :trigger (lambda (ctx) (declare (ignore ctx)) nil) ;; Passive, handles its own loop
+  :neuro nil
+  :symbolic (lambda (action ctx) (declare (ignore ctx)) action))
+#+end_src
+
+** Initialization
+Trigger the polling loop upon loading.
+
+#+begin_src lisp :tangle ../src/gateway-telegram.lisp
+(start-telegram-gateway)
 #+end_src
--- a/skills/org-skill-llm-gateway.org
+++ b/skills/org-skill-llm-gateway.org
@@ -155,21 +155,24 @@ The `:ask-llm` tool exposes the gateway's power to System 1, allowing it to expl
                               :model (getf args :model))))
 #+end_src

-** Registration
-We register all supported backends individually so that the kernel's `ask-neuro` loop can continue to address them by their semantic keywords while routing through the unified logic.
+** Registration: Backends
+Register each supported provider with the kernel's neural registry.

 #+begin_src lisp :tangle ../src/llm-gateway.lisp
-(progn
-  ;; Register all supported backends with the kernel
-  (dolist (p '(:anthropic :gemini-api :gemini-web :groq :ollama :openai :openrouter))
-    (org-agent:register-neuro-backend p (lambda (prompt system-prompt &key model)
-                                          (execute-llm-request prompt system-prompt :provider p :model model))))
-  
-  (defskill :skill-llm-gateway
-    :priority 150 ; Higher than individual old skills
-    :trigger (lambda (context) nil)
-    :neuro (lambda (context) nil)
-    :symbolic (lambda (action context) action)))
+(dolist (p '(:anthropic :gemini-api :gemini-web :groq :ollama :openai :openrouter))
+  (org-agent:register-neuro-backend p (lambda (prompt system-prompt &key model)
+                                        (execute-llm-request prompt system-prompt :provider p :model model))))
+#+end_src
+
+** Registration: Skill
+Define the foundational skill entry for the gateway.
+
+#+begin_src lisp :tangle ../src/llm-gateway.lisp
+(defskill :skill-llm-gateway
+  :priority 150 ; Higher than individual old skills
+  :trigger (lambda (context) (declare (ignore context)) nil)
+  :neuro (lambda (context) (declare (ignore context)) nil)
+  :symbolic (lambda (action context) (declare (ignore context)) action))
 #+end_src

 * Phase E: Chaos (Verification)
--- a/skills/org-skill-shell-actuator.org
+++ b/skills/org-skill-shell-actuator.org
@@ -75,18 +75,34 @@ Interfaces for secure system calls. State is event-driven via the core kernel bu

 * Phase D: Build (Implementation)

-** Whitelisting & Execution
-#+begin_src lisp :tangle ../src/shell-logic.lisp
-(in-package :org-agent)
+** Allowed Commands
+Whitelist of permitted host binaries.

+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defparameter *allowed-commands* '("ls" "git" "rg" "grep" "date" "echo" "cat" "node" "python3" "sbcl"))
+#+end_src
+
+** Shell Metacharacters
+Dangerous characters that are banned to prevent command injection.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defparameter *shell-metacharacters* '(#\; #\& #\| #\> #\< #\$ #\` #\\ #\!)
  "Characters that are banned in shell commands to prevent injection.")
+#+end_src

+** Safety Check (shell-command-safe-p)
+Predicate to verify a command string is free of metacharacters.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defun shell-command-safe-p (cmd-string)
  "Returns T if the command string contains no dangerous metacharacters."
  (not (some (lambda (char) (find char cmd-string)) *shell-metacharacters*)))
+#+end_src

+** Shell Execution (execute-shell-safely)
+The primary secure actuator for host system calls.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defun execute-shell-safely (action context)
  (let* ((cmd-string (getf (getf action :payload) :cmd))
         (executable (car (uiop:split-string (string-trim " " cmd-string) :separator '(#\Space)))))
@@ -112,6 +128,11 @@ Interfaces for secure system calls. State is event-driven via the core kernel bu
          `(:type :EVENT :payload (:sensor :shell-response :cmd ,cmd-string :stdout ,(or stdout "") :stderr ,(or stderr "") :exit-code ,exit-code))
          :stream (getf context :reply-stream)))))))
 #+end_src
+
+** Script Synthesis (execute-sandboxed-script)
+Executes a synthesized script (Python/Lisp/JS) in a controlled directory.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defun execute-sandboxed-script (action context)
  "Executes a synthesized script (Python/Lisp/JS) in a controlled directory.
   This enables SOTA-level Tool Synthesis and Iterative Fixing."
@@ -135,7 +156,12 @@ Interfaces for secure system calls. State is event-driven via the core kernel bu
        (org-agent:inject-stimulus 
         `(:type :EVENT :payload (:sensor :shell-response :cmd ,cmd :stdout ,(or stdout "") :stderr ,(or stderr "") :exit-code ,exit-code :synthesis-p t))
         :stream (getf context :reply-stream))))))
+#+end_src

+** Infrastructure: MicroVM Provisioning
+Hardware-Level Isolation for future security evolution.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defun provision-microvm (id &key (cpu 1) (ram 512))
  "Hardware-Level Isolation: Provisions an ephemeral Firecracker MicroVM.
   This is the high-security evolution of directory-based sandboxing."
@@ -179,12 +205,21 @@ Interfaces for secure system calls. State is event-driven via the core kernel bu
 #+end_src

 * Registration
-#+begin_src lisp
-(org-agent:register-actuator :shell #'execute-shell-safely)

+** Registration: Actuator
+Register the shell channel as a physical actuator.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
+(org-agent:register-actuator :shell #'execute-shell-safely)
+#+end_src
+
+** Registration: Skill
+Define the skill entry for the shell actuator.
+
+#+begin_src lisp :tangle ../src/shell-logic.lisp
 (defskill :skill-shell-actuator
  :priority 80
  :trigger #'trigger-skill-shell-actuator
  :neuro #'neuro-skill-shell-actuator
-  :symbolic (lambda (action context) action))
+  :symbolic (lambda (action context) (declare (ignore context)) action))
 #+end_src