Amr Gharbeia
8fd56dece3
Phase 1 — dedup + hardening (~9 items): - Remove duplicate *skill-registry* defvar from core-skills - Merge *backend-registry* into *probabilistic-backends*, delete backend-register - Remove inject-stimulus alias, standardize on stimulus-inject - Add pre-eval sandbox (skill-source-scan) blocks restricted symbols before eval - Remove dead plist-get function; remove duplicate json-alist-to-plist export - Fix read-framed-message whitespace DoS (4096-iteration max) - Add *read-eval* nil to dispatcher-approvals-process read-from-string (RCE) - Add test-op to ASDF; update .asd version 0.4.3→0.7.2 Phase 2 — prose + contracts + reorder: - Split ROADMAP: 2623→1089 lines (TODO only), CHANGELOG: 260→1528 lines (full DONE history, 14 versions reverse chron) - Add Contracts + Overview to 6 channel files + embedding-native + programming-standards + symbolic-scope - Reorder 28 .org files: Contract → Test Suite → Implementation (TDD order) - Add 7-phase inline prose to think() in core-reason - Expand USER_MANUAL: 183→461 lines (10 new sections) Phase 3 — decomposition + export organization: - Decompose think() into think-assemble-prompt, think-call-llm, think-parse-response orchestrator - Organize 188 exports into 16 grouped sections by module Phase 4 — budget enforcement + error protocol: - Per-session budget enforcement (SESSION_BUDGET_USD env var, budget-exhausted-p, guard in think-call-llm) - Error condition hierarchy (6 conditions: pipeline-error, llm-error, gate-error, budget-error, protocol-error) - Restarts in loop-process: skip-signal, use-fallback, abort-pipeline
255 lines
12 KiB
Common Lisp
255 lines
12 KiB
Common Lisp
(eval-when (:compile-toplevel :load-toplevel :execute)
|
|
(ql:quickload :fiveam :silent t))
|
|
|
|
(defpackage :passepartout-token-economics-tests
|
|
(:use :cl :fiveam :passepartout)
|
|
(:export #:token-economics-suite))
|
|
|
|
(in-package :passepartout-token-economics-tests)
|
|
|
|
(def-suite token-economics-suite
|
|
:description "Prompt prefix caching, incremental context, token budget")
|
|
(in-suite token-economics-suite)
|
|
|
|
(test test-prompt-prefix-cached-identity
|
|
"Contract 1: prompt-prefix-cached includes identity-content when provided."
|
|
(setf (car passepartout::*prompt-prefix-cache*) nil
|
|
(cdr passepartout::*prompt-prefix-cache*) "")
|
|
(let ((prefix (passepartout::prompt-prefix-cached
|
|
"Agent" "### Mode: concise" "" nil "No tools")))
|
|
(is (stringp prefix))
|
|
(is (search "IDENTITY" prefix))
|
|
(is (search "Mode: concise" prefix))
|
|
(is (search "TOOLS" prefix))))
|
|
|
|
(test test-prompt-prefix-cached-builds
|
|
"Contract 1: prompt-prefix-cached returns a string containing IDENTITY."
|
|
(setf (car passepartout::*prompt-prefix-cache*) nil
|
|
(cdr passepartout::*prompt-prefix-cache*) "")
|
|
(let ((prefix (passepartout::prompt-prefix-cached "Agent" "" "" nil "No tools")))
|
|
(is (stringp prefix))
|
|
(is (search "IDENTITY" prefix))
|
|
(is (search "TOOLS" prefix))))
|
|
|
|
(test test-prompt-prefix-cached-hits
|
|
"Contract 1: second call with same inputs returns cached result."
|
|
(setf (car passepartout::*prompt-prefix-cache*) nil
|
|
(cdr passepartout::*prompt-prefix-cache*) "")
|
|
(let ((p1 (passepartout::prompt-prefix-cached "Agent" "" "" nil "No tools"))
|
|
(p2 (passepartout::prompt-prefix-cached "Agent" "" "" nil "No tools")))
|
|
(is (string= p1 p2))))
|
|
|
|
(test test-prompt-prefix-cached-miss
|
|
"Contract 1: different inputs rebuild the cache."
|
|
(setf (car passepartout::*prompt-prefix-cache*) nil
|
|
(cdr passepartout::*prompt-prefix-cache*) "")
|
|
(let ((p1 (passepartout::prompt-prefix-cached "Agent" "" "" nil "No tools"))
|
|
(p2 (passepartout::prompt-prefix-cached "Bot" "" "" nil "No tools")))
|
|
(is (not (string= p1 p2)))
|
|
(is (search "Bot" p2))))
|
|
|
|
(test test-context-assemble-cached-skips-heartbeat
|
|
"Contract 2: heartbeat sensors skip context assembly, return nil."
|
|
(let ((result (passepartout::context-assemble-cached
|
|
'(:foveal-focus "id1") :heartbeat)))
|
|
(is (null result))))
|
|
|
|
(test test-context-assemble-cached-skips-delegation
|
|
"Contract 2: delegation sensors also skip assembly."
|
|
(let ((result (passepartout::context-assemble-cached
|
|
'(:foveal-focus "id1") :delegation)))
|
|
(is (null result))))
|
|
|
|
(test test-context-assemble-cached-non-skip
|
|
"Contract 2: user-input sensors attempt assembly (fails gracefully without awareness)."
|
|
(let ((result (passepartout::context-assemble-cached
|
|
'(:foveal-focus "id1") :user-input)))
|
|
(is (stringp result))
|
|
(is (> (length result) 0))))
|
|
|
|
(test test-enforce-token-budget-passthrough
|
|
"Contract 3: under-budget prompts pass through unchanged."
|
|
(multiple-value-bind (p c l u m)
|
|
(passepartout::enforce-token-budget "hi" "ctxt" "log" "user" nil 100000)
|
|
(is (string= "hi" p))
|
|
(is (string= "ctxt" c))
|
|
(is (string= "log" l))
|
|
(is (string= "user" u))
|
|
(is (null m))))
|
|
|
|
(test test-enforce-token-budget-trims
|
|
"Contract 3: over-budget prompts get trimmed."
|
|
(let ((big-prefix (make-string 20000 :initial-element #\x)))
|
|
(multiple-value-bind (p c l u m)
|
|
(passepartout::enforce-token-budget big-prefix "ctxt" "logs\nlogs\nlogs\nlogs\nlogs\nlogs\nlogs" "user" nil 10)
|
|
(declare (ignore p l u m))
|
|
;; The prefix itself exceeds the tiny 10-token budget, so everything gets trimmed
|
|
(is (or (stringp c) (null c)))
|
|
(is (search "[Context trimmed" (or c ""))))))
|
|
|
|
(test test-token-economics-initialize
|
|
"Contract 4: initialize zeroes all cache state."
|
|
(setf (car passepartout::*prompt-prefix-cache*) 12345
|
|
(cdr passepartout::*prompt-prefix-cache*) "stale")
|
|
(setf (getf passepartout::*context-cache* :rendered) "stale context")
|
|
(passepartout::token-economics-initialize)
|
|
(is (null (car passepartout::*prompt-prefix-cache*)))
|
|
(is (string= "" (cdr passepartout::*prompt-prefix-cache*)))
|
|
(is (string= "" (getf passepartout::*context-cache* :rendered))))
|
|
|
|
(in-package :passepartout)
|
|
|
|
(defvar *prompt-prefix-cache* (cons nil "")
|
|
"Prompt prefix cache: (sxhash . cached-string). Rebuilt when IDENTITY or TOOLS change.")
|
|
|
|
(defvar *context-cache* (list :foveal-id nil :scope nil :memory-timestamp 0 :rendered ""
|
|
:identity-tokens 0 :tool-tokens 0 :context-tokens 0
|
|
:log-tokens 0 :config-tokens 0 :time-tokens 0)
|
|
"Context assembly cache: metadata + last rendered context string.")
|
|
|
|
(defun prompt-prefix-cached (assistant-name identity-content feedback mandates-text tool-belt)
|
|
"Build the static IDENTITY+TOOLS system prompt prefix.
|
|
Uses sxhash on inputs to detect changes; returns cached string on cache hit."
|
|
(let* ((hash-key (sxhash (list assistant-name identity-content feedback mandates-text tool-belt)))
|
|
(cached-hash (car *prompt-prefix-cache*))
|
|
(cached-str (cdr *prompt-prefix-cache*)))
|
|
(if (and cached-str (> (length cached-str) 0) (= hash-key cached-hash))
|
|
cached-str
|
|
(let ((new-prefix (format nil "IDENTITY: ~a~a~a~a~%~%TOOLS:~%~a"
|
|
assistant-name identity-content feedback
|
|
(if (and mandates-text (> (length mandates-text) 0))
|
|
(concatenate 'string (string #\Newline) mandates-text)
|
|
"")
|
|
tool-belt)))
|
|
(setf (car *prompt-prefix-cache*) hash-key
|
|
(cdr *prompt-prefix-cache*) new-prefix)
|
|
new-prefix))))
|
|
|
|
(defun context-assemble-cached (context sensor)
|
|
"Incrementally assemble awareness context.
|
|
Skips assembly for heartbeat/delegation sensors.
|
|
Uses cache when foveal, scope, and memory timestamp are unchanged."
|
|
(when (member sensor '(:heartbeat :delegation))
|
|
(return-from context-assemble-cached nil))
|
|
(unless (fboundp 'context-assemble-global-awareness)
|
|
(return-from context-assemble-cached "[Awareness skill not loaded]"))
|
|
(let* ((foveal-id (getf context :foveal-focus))
|
|
(scope (if (and (boundp '*scope-resolver*)
|
|
*scope-resolver*)
|
|
(funcall *scope-resolver*)
|
|
nil))
|
|
(mem-ts (hash-table-count *memory-store*))
|
|
(cache-foveal (getf *context-cache* :foveal-id))
|
|
(cache-scope (getf *context-cache* :scope))
|
|
(cache-ts (getf *context-cache* :memory-timestamp))
|
|
(cache-rendered (getf *context-cache* :rendered)))
|
|
(if (and (equal foveal-id cache-foveal)
|
|
(eq scope cache-scope)
|
|
(= mem-ts cache-ts)
|
|
cache-rendered
|
|
(> (length cache-rendered) 0))
|
|
cache-rendered
|
|
(let ((rendered (funcall (symbol-function 'context-assemble-global-awareness))))
|
|
(setf (getf *context-cache* :foveal-id) foveal-id
|
|
(getf *context-cache* :scope) scope
|
|
(getf *context-cache* :memory-timestamp) mem-ts
|
|
(getf *context-cache* :rendered) rendered)
|
|
rendered))))
|
|
|
|
(defun enforce-token-budget (prefix context-text logs-text user-prompt mandates-text
|
|
&optional (max-tokens nil))
|
|
"Enforce per-call token budget via progressive trimming.
|
|
Returns (values prefix context-text logs-text user-prompt mandates-text)
|
|
with trimmed sections."
|
|
(let ((max (or max-tokens
|
|
(ignore-errors
|
|
(parse-integer (uiop:getenv "CONTEXT_MAX_TOKENS")))
|
|
16384)))
|
|
(labels ((ct (s) (if (fboundp 'count-tokens)
|
|
(funcall (symbol-function 'count-tokens) s)
|
|
(ceiling (length s) 4)))
|
|
(total-tokens (p c l u m)
|
|
(+ (ct p)
|
|
(if c (ct c) 0)
|
|
(ct l)
|
|
(ct u)
|
|
(if m (ct m) 0))))
|
|
(let ((total (total-tokens prefix context-text logs-text user-prompt mandates-text)))
|
|
(when (> total max)
|
|
(log-message "TOKEN BUDGET: ~d tokens exceeds max ~d, trimming..."
|
|
total max)
|
|
;; L1: truncate logs to last 5 lines
|
|
(let* ((log-lines (uiop:split-string logs-text :separator '(#\Newline)))
|
|
(trimmed (if (> (length log-lines) 5)
|
|
(format nil "~{~a~^~%~}" (last log-lines 5))
|
|
logs-text)))
|
|
(setf total (total-tokens prefix context-text trimmed user-prompt mandates-text)
|
|
logs-text trimmed)
|
|
(when (> total max)
|
|
;; L2: drop standing mandates
|
|
(setf total (total-tokens prefix context-text logs-text user-prompt nil)
|
|
mandates-text nil)
|
|
(when (> total max)
|
|
;; L3: downgrade context to summary
|
|
(let ((ctxt-lines (uiop:split-string (or context-text "") :separator '(#\Newline))))
|
|
(setf context-text
|
|
(format nil "[Context trimmed: ~d items]" (length ctxt-lines)))))))))
|
|
(values prefix context-text logs-text user-prompt mandates-text))))
|
|
|
|
(defun token-economics-initialize ()
|
|
"Zero cache state at daemon boot."
|
|
(setf (car *prompt-prefix-cache*) nil
|
|
(cdr *prompt-prefix-cache*) ""
|
|
(getf *context-cache* :foveal-id) nil
|
|
(getf *context-cache* :scope) nil
|
|
(getf *context-cache* :memory-timestamp) 0
|
|
(getf *context-cache* :rendered) ""))
|
|
|
|
(defun context-usage-percentage ()
|
|
"Returns integer 0-100: current token budget consumption.
|
|
Returns nil when no context cache data is available."
|
|
(let* ((limit (or (ignore-errors
|
|
(parse-integer (uiop:getenv "CONTEXT_MAX_TOKENS")))
|
|
16384))
|
|
(tokens (+ (or (getf *context-cache* :identity-tokens) 0)
|
|
(or (getf *context-cache* :tool-tokens) 0)
|
|
(or (getf *context-cache* :context-tokens) 0)
|
|
(or (getf *context-cache* :log-tokens) 0)
|
|
(or (getf *context-cache* :config-tokens) 0)
|
|
(or (getf *context-cache* :time-tokens) 0))))
|
|
(if (> tokens 0)
|
|
(min 100 (floor (* 100 tokens) limit))
|
|
nil)))
|
|
|
|
(in-package :passepartout-token-economics-tests)
|
|
|
|
(test test-context-usage-percentage
|
|
"Contract 5: context-usage-percentage returns integer 0-100."
|
|
;; Set up a cache with known token counts
|
|
(let* ((ctx passepartout::*context-cache*)
|
|
(limit (or (ignore-errors (parse-integer (uiop:getenv "CONTEXT_MAX_TOKENS")))
|
|
16384)))
|
|
(setf (getf ctx :identity-tokens) 1000
|
|
(getf ctx :tool-tokens) 500
|
|
(getf ctx :context-tokens) 2000
|
|
(getf ctx :log-tokens) 800
|
|
(getf ctx :config-tokens) 200
|
|
(getf ctx :time-tokens) 100)
|
|
(let ((pct (passepartout::context-usage-percentage)))
|
|
(is (integerp pct))
|
|
(is (<= 0 pct 100)))))
|
|
|
|
(test test-context-usage-percentage-empty-cache
|
|
"Contract 5: context-usage-percentage returns nil with no cache data."
|
|
(let ((saved-ctx (copy-list passepartout::*context-cache*)))
|
|
(unwind-protect
|
|
(progn
|
|
(setf (getf passepartout::*context-cache* :identity-tokens) nil
|
|
(getf passepartout::*context-cache* :tool-tokens) nil
|
|
(getf passepartout::*context-cache* :context-tokens) nil
|
|
(getf passepartout::*context-cache* :log-tokens) nil
|
|
(getf passepartout::*context-cache* :config-tokens) nil
|
|
(getf passepartout::*context-cache* :time-tokens) nil)
|
|
(is (null (passepartout::context-usage-percentage))))
|
|
(setf passepartout::*context-cache* saved-ctx))))
|