Amr Gharbeia
a31f19045a
Some checks failed
Deploy (Gitea) / deploy (push) Failing after 3s
Wrap read-from-string/read with (let ((*read-eval* nil)) ...) at three untrusted-input code paths: 1. think() in core-loop-reason — LLM output parsing. LLM output is untrusted by definition; #.(shell ...) in a response must not execute. 2. action-system-execute in core-loop-act — :system :eval path processes untrusted payload code from the signal pipeline. 3. load-memory-from-disk in core-memory — memory.snap file could be corrupted or planted in ~/, must not execute #. reader macros. Adds test-read-eval-rce-blocked to pipeline-reason-suite: mocks a backend returning malicious output containing #.(setf ...), verifies no side effects occur and safe fallback is returned. RED proof recorded: *read-eval* T + #.(setf ...) → :PWNED (RCE active) GREEN proof: *read-eval* NIL → reader-error caught (RCE blocked) Test: reason 12/0, full suite 88/0
214 lines
10 KiB
Common Lisp
214 lines
10 KiB
Common Lisp
(in-package :passepartout)
|
|
|
|
(defvar *memory-store* (make-hash-table :test 'equal))
|
|
|
|
(defvar *memory-history* (make-hash-table :test 'equal)
|
|
"Immutable Merkle-Tree versioning store mapping hashes to objects.")
|
|
|
|
(defun memory-object-get (id)
|
|
"Retrieves an memory-object by ID from *memory-store*."
|
|
(gethash id *memory-store*))
|
|
|
|
(defun memory-objects-by-attribute (attr value)
|
|
"Returns all memory-objects whose :ATTRIBUTES plist has ATTR = VALUE."
|
|
(let ((results nil))
|
|
(maphash (lambda (id obj)
|
|
(declare (ignore id))
|
|
(when (equal (getf (memory-object-attributes obj) attr) value)
|
|
(push obj results)))
|
|
*memory-store*)
|
|
(nreverse results)))
|
|
|
|
(defun memory-id-generate ()
|
|
"Generates a UUIDv4 unique ID. Compatible with Agora Note UUIDs."
|
|
(concatenate 'string "id-" (string-downcase (format nil "~a" (uuid:make-v4-uuid)))))
|
|
|
|
(defstruct memory-object
|
|
id type attributes content vector parent-id children version last-sync hash scope)
|
|
|
|
(defmethod make-load-form ((obj memory-object) &optional env)
|
|
(make-load-form-saving-slots obj :environment env))
|
|
|
|
(defun deep-copy-memory-object (obj)
|
|
"Creates a full copy of an memory-object, including fresh lists for attributes and children."
|
|
(make-memory-object :id (memory-object-id obj)
|
|
:type (memory-object-type obj)
|
|
:attributes (copy-list (memory-object-attributes obj))
|
|
:content (memory-object-content obj)
|
|
:vector (memory-object-vector obj)
|
|
:parent-id (memory-object-parent-id obj)
|
|
:children (copy-list (memory-object-children obj))
|
|
:version (memory-object-version obj)
|
|
:last-sync (memory-object-last-sync obj)
|
|
:hash (memory-object-hash obj)
|
|
:scope (memory-object-scope obj)))
|
|
|
|
(defun memory-merkle-hash (id type attributes content child-hashes)
|
|
(let* ((alist (loop for (k v) on attributes by #'cddr collect (cons k v)))
|
|
(sorted-alist (sort alist #'string< :key (lambda (x) (format nil "~a" (car x)))))
|
|
(attr-string (format nil "~s" sorted-alist))
|
|
(children-string (format nil "~{~a~}" child-hashes))
|
|
(data-string (format nil "ID:~a|TYPE:~s|ATTRS:~a|CONTENT:~a|CHILDREN:~a"
|
|
id type attr-string (or content "") children-string))
|
|
(digester (ironclad:make-digest :sha256)))
|
|
(ironclad:update-digest digester (ironclad:ascii-string-to-byte-array data-string))
|
|
(ironclad:byte-array-to-hex-string (ironclad:produce-digest digester))))
|
|
|
|
(defun ingest-ast (ast &key parent-id (scope :memex))
|
|
(let* ((type (getf ast :type))
|
|
(props (getf ast :properties))
|
|
(id (or (getf props :ID) (format nil "temp-~a" (get-universal-time))))
|
|
(contents (getf ast :contents))
|
|
(raw-content (when (eq type :HEADLINE)
|
|
(format nil "~a~%~a" (getf props :TITLE) (or (getf ast :raw-content) ""))))
|
|
(child-ids nil) (child-hashes nil))
|
|
(dolist (child contents)
|
|
(when (listp child)
|
|
(let ((child-id (ingest-ast child :parent-id id :scope scope)))
|
|
(push child-id child-ids)
|
|
(let ((child-obj (gethash child-id *memory-store*)))
|
|
(when child-obj (push (memory-object-hash child-obj) child-hashes))))))
|
|
(setf child-ids (nreverse child-ids))
|
|
(setf child-hashes (nreverse child-hashes))
|
|
(let* ((hash (memory-merkle-hash id type props raw-content child-hashes))
|
|
(existing-obj (gethash hash *memory-history*))
|
|
(obj (or existing-obj
|
|
(make-memory-object
|
|
:id id :type type :attributes props :content raw-content
|
|
:parent-id parent-id :children child-ids
|
|
:version (get-universal-time) :last-sync (get-universal-time)
|
|
:hash hash :scope scope))))
|
|
(unless existing-obj (setf (gethash hash *memory-history*) obj))
|
|
(setf (gethash id *memory-store*) obj)
|
|
;; Populate embedding vector for new objects
|
|
(when (and raw-content (not existing-obj) (not (memory-object-vector obj)))
|
|
(handler-case
|
|
(setf (memory-object-vector obj)
|
|
(embeddings-compute raw-content))
|
|
(error (c)
|
|
(log-message "INGEST: Embedding deferred: ~a" c))))
|
|
id)))
|
|
|
|
(defvar *memory-snapshots* nil)
|
|
|
|
(defun memory-hash-table-copy (hash-table)
|
|
"Creates an independent copy of a hash table."
|
|
(let ((new-table (make-hash-table :test (hash-table-test hash-table)
|
|
:size (hash-table-size hash-table))))
|
|
(maphash (lambda (k v) (setf (gethash k new-table) v)) hash-table)
|
|
new-table))
|
|
|
|
(defun snapshot-memory ()
|
|
"Creates a CoW snapshot of *memory-store* for rollback recovery."
|
|
(let ((snapshot (make-hash-table :test 'equal :size (hash-table-size *memory-store*))))
|
|
(maphash (lambda (k v) (setf (gethash k snapshot) (deep-copy-memory-object v))) *memory-store*)
|
|
(push (list :timestamp (get-universal-time) :data snapshot) *memory-snapshots*)
|
|
(when (> (length *memory-snapshots*) 20)
|
|
(setf *memory-snapshots* (subseq *memory-snapshots* 0 20)))
|
|
(log-message "MEMORY - CoW Memory snapshot created.")))
|
|
|
|
(defun rollback-memory (&optional (index 0))
|
|
"Restores *memory-store* from a snapshot. INDEX 0 = most recent."
|
|
(let ((snapshot (nth index *memory-snapshots*)))
|
|
(if snapshot
|
|
(progn (setf *memory-store* (memory-hash-table-copy (getf snapshot :data)))
|
|
(log-message "MEMORY - Memory rolled back to snapshot ~a" index))
|
|
(log-message "MEMORY ERROR - Snapshot ~a not found." index))))
|
|
|
|
(defvar *memory-snapshot-path* nil)
|
|
|
|
(defun memory-snapshot-path-ensure ()
|
|
"Returns the path to the memory snapshot file, resolving env or default."
|
|
(or *memory-snapshot-path*
|
|
(let ((env-path (uiop:getenv "MEMORY_SNAPSHOT_PATH")))
|
|
(setf *memory-snapshot-path*
|
|
(or env-path (namestring (uiop:merge-pathnames* "memory.snap" (user-homedir-pathname))))))))
|
|
|
|
(defun save-memory-to-disk ()
|
|
"Writes the entire memory and history store to disk as a plist."
|
|
(let ((path (memory-snapshot-path-ensure)))
|
|
(with-open-file (stream path :direction :output :if-exists :supersede :if-does-not-exist :create)
|
|
(let ((memory-alist nil) (history-alist nil))
|
|
(maphash (lambda (k v) (push (cons k v) memory-alist)) *memory-store*)
|
|
(maphash (lambda (k v) (push (cons k v) history-alist)) *memory-history*)
|
|
(prin1 (list :memory memory-alist :history-store history-alist) stream)))
|
|
(log-message "MEMORY - Saved to ~a" path)))
|
|
|
|
(defun load-memory-from-disk ()
|
|
"Reads memory state from disk and restores *memory-store* and *memory-history*."
|
|
(let ((path (memory-snapshot-path-ensure)))
|
|
(when (uiop:file-exists-p path)
|
|
(handler-case
|
|
(with-open-file (stream path :direction :input)
|
|
(let ((data (let ((*read-eval* nil)) (read stream nil))))
|
|
(when data
|
|
(let ((memory-alist (getf data :memory)) (history-alist (getf data :history-store)))
|
|
(setf *memory-store* (make-hash-table :test 'equal :size (length memory-alist)))
|
|
(dolist (kv memory-alist) (setf (gethash (car kv) *memory-store*) (cdr kv)))
|
|
(setf *memory-history* (make-hash-table :test 'equal :size (length history-alist)))
|
|
(dolist (kv history-alist) (setf (gethash (car kv) *memory-history*) (cdr kv)))
|
|
(log-message "MEMORY - Loaded from ~a (~a objects)" path (hash-table-size *memory-store*))))))
|
|
(error (c) (log-message "MEMORY WARNING - Failed to load snapshot: ~a" c)))))
|
|
t)
|
|
|
|
(eval-when (:compile-toplevel :load-toplevel :execute)
|
|
(ql:quickload :fiveam :silent t))
|
|
|
|
(defpackage :passepartout-memory-tests
|
|
(:use :cl :fiveam :passepartout)
|
|
(:export #:memory-suite))
|
|
|
|
(in-package :passepartout-memory-tests)
|
|
|
|
(def-suite memory-suite :description "Tests for the Merkle-Tree Memory")
|
|
(in-suite memory-suite)
|
|
|
|
(test merkle-hash-consistency
|
|
"Contract 2: identical ASTs produce identical Merkle hashes."
|
|
(let* ((ast1 '(:type :HEADLINE :properties (:ID "test-1" :TITLE "Node 1") :contents nil)))
|
|
(clrhash passepartout::*memory-store*)
|
|
(let ((id1 (ingest-ast ast1)))
|
|
(let ((hash1 (memory-object-hash (memory-object-get id1))))
|
|
(clrhash passepartout::*memory-store*)
|
|
(let ((id2 (ingest-ast ast1)))
|
|
(is (equal hash1 (memory-object-hash (memory-object-get id2)))))))))
|
|
|
|
(test merkle-hash-different
|
|
"Contract 2: distinct ASTs produce different Merkle hashes."
|
|
(clrhash passepartout::*memory-store*)
|
|
(let* ((ast1 '(:type :HEADLINE :properties (:ID "a" :TITLE "Alpha") :contents nil))
|
|
(ast2 '(:type :HEADLINE :properties (:ID "b" :TITLE "Beta") :contents nil))
|
|
(id1 (ingest-ast ast1))
|
|
(id2 (ingest-ast ast2))
|
|
(hash1 (memory-object-hash (memory-object-get id1)))
|
|
(hash2 (memory-object-hash (memory-object-get id2))))
|
|
(is (not (equal hash1 hash2)))))
|
|
|
|
(test test-ingest-ast-returns-id
|
|
"Contract 1: ingest-ast returns a string ID and stores the object."
|
|
(clrhash passepartout::*memory-store*)
|
|
(let ((id (ingest-ast '(:type :HEADLINE :properties (:ID "ingest-test" :TITLE "Test Node") :contents nil))))
|
|
(is (stringp id))
|
|
(is (not (null id)))))
|
|
|
|
(test test-memory-object-get
|
|
"Contract 3: memory-object-get retrieves an object by ID after ingest."
|
|
(clrhash passepartout::*memory-store*)
|
|
(let ((id (ingest-ast '(:type :HEADLINE :properties (:ID "get-test" :TITLE "Retrieve Me") :contents nil))))
|
|
(let ((obj (memory-object-get id)))
|
|
(is (not (null obj)))
|
|
(is (eq :HEADLINE (memory-object-type obj)))
|
|
(is (string= "Retrieve Me" (getf (memory-object-attributes obj) :TITLE))))))
|
|
|
|
(test test-snapshot-and-rollback
|
|
"Contract 4+5: snapshot-memory saves state; rollback-memory restores it."
|
|
(clrhash passepartout::*memory-store*)
|
|
(setf passepartout::*memory-snapshots* nil)
|
|
(ingest-ast '(:type :HEADLINE :properties (:ID "snap-a" :TITLE "Pre-snapshot") :contents nil))
|
|
(snapshot-memory)
|
|
(clrhash passepartout::*memory-store*)
|
|
(ingest-ast '(:type :HEADLINE :properties (:ID "snap-b" :TITLE "Post-snapshot") :contents nil))
|
|
(rollback-memory 0)
|
|
(is (not (null (memory-object-get "snap-a"))))
|
|
(is (null (memory-object-get "snap-b"))))
|