Amr Gharbeia
b62b7f1095
Some checks failed
Deploy-Agent-V15-Stdin / JOB-V15-STDIN (push) Failing after 3s
- Relax validate-communication-protocol-schema to accept :REQUEST messages without :target when :source is present in :meta (reason-gate infers target from source). - This preserves 'equality of clients' — gateways don't duplicate routing logic. - Add communication-validator to ASD components. - Fixes TCP CLI gateway integration: clients can now connect and receive responses. - Verified with test client: 13/13 skills load, Perceive gate processes messages.
45 lines
2.1 KiB
Common Lisp
45 lines
2.1 KiB
Common Lisp
(in-package :opencortex)
|
|
|
|
(defun validate-communication-protocol-schema (msg)
|
|
"Strict structural validation for incoming communication protocol messages."
|
|
(unless (listp msg)
|
|
(error "Communication Protocol Schema Error: Message must be a property list (got ~s)" (type-of msg)))
|
|
|
|
(let ((type (let ((raw (proto-get msg :type))) (if (keywordp raw) (intern (string-upcase (string raw)) :keyword) raw))))
|
|
(unless (member type '(:REQUEST :EVENT :RESPONSE :LOG :STATUS))
|
|
(progn (harness-log "REJECTED MSG: ~s" msg) (error "Communication Protocol Schema Error: Invalid message type '~a'" type)))
|
|
|
|
(case type
|
|
(:REQUEST
|
|
;; Allow missing :target if :source is present in :meta, since reason-gate
|
|
;; will infer :target from :source downstream. This preserves "equality of
|
|
;; clients" — gateways need not duplicate routing logic.
|
|
(let ((target (proto-get msg :target))
|
|
(source (proto-get (proto-get msg :meta) :source)))
|
|
(unless (or target source)
|
|
(error "Communication Protocol Schema Error: REQUEST missing mandatory :target and no :source in :meta to infer it"))
|
|
(unless (proto-get msg :payload)
|
|
(error "Communication Protocol Schema Error: REQUEST missing mandatory :payload"))))
|
|
|
|
(:EVENT
|
|
(let ((payload (proto-get msg :payload)))
|
|
(unless (and payload (listp payload))
|
|
(error "Communication Protocol Schema Error: EVENT missing or invalid :payload"))
|
|
(unless (or (proto-get payload :action) (proto-get payload :sensor))
|
|
(error "Communication Protocol Schema Error: EVENT payload must contain :action or :sensor"))))
|
|
|
|
(:RESPONSE
|
|
(unless (proto-get msg :payload)
|
|
(error "Communication Protocol Schema Error: RESPONSE missing mandatory :payload"))))
|
|
|
|
t))
|
|
|
|
(defskill :skill-communication-protocol-validator
|
|
:priority 95
|
|
:trigger (lambda (ctx) (member (getf (getf ctx :payload) :sensor) '(:protocol-received)))
|
|
:probabilistic nil
|
|
:deterministic (lambda (action ctx)
|
|
(declare (ignore ctx))
|
|
(validate-communication-protocol-schema action)
|
|
action))
|