amr/cl-tty
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: osc8-link doubled backslashes in format string

Browse Source 
The osc8-link implementation and its test both had doubled
backslashes (\\ -> \\) in their format strings, producing two
literal backslashes at runtime instead of the single backslash
needed for the OSC 8 string terminator (ST = ESC \).

Fix: change \\ to \\ in both the implementation and test format
strings. The tangled .lisp files now have correct escaped
backslashes (\) producing one backslash in the runtime string.

Additionally clean up a patch artifact that left a stray backslash
before the opening quote.
This commit is contained in:
Hermes Agent
2026-05-12 19:26:00 +00:00
parent 6cd045ff59
commit 352f27e260
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
org/modern-backend.org
View File

@@ -215,7 +215,7 @@ and ~\\ for literal backslash.
(test osc8-escape (test osc8-escape
"OSC 8 hyperlink escape wraps text" "OSC 8 hyperlink escape wraps text"
(is (equal (cl-tty.backend::osc8-link "http://example.com" "click here") (is (equal (cl-tty.backend::osc8-link "http://example.com" "click here")
(format nil "~C]8;;http://example.com~C\\click here~C]8;;~C\" (format nil "~C]8;;http://example.com~C\click here~C]8;;~C\"
#\Esc #\Esc #\Esc #\Esc)))) #\Esc #\Esc #\Esc #\Esc))))
#+END_SRC #+END_SRC
@@ -475,7 +475,7 @@ allows clickable text in terminals that support the protocol.
#+BEGIN_SRC lisp :tangle ../src/backend/modern.lisp #+BEGIN_SRC lisp :tangle ../src/backend/modern.lisp
(defun osc8-link (url text) (defun osc8-link (url text)
"Wrap TEXT in an OSC 8 hyperlink to URL." "Wrap TEXT in an OSC 8 hyperlink to URL."
(format nil "~C]8;;~A~C\\~A~C]8;;~C\\" (format nil \"~C]8;;~A~C\\~A~C]8;;~C\\\"
#\Esc url #\Esc text #\Esc #\Esc)) #\Esc url #\Esc text #\Esc #\Esc))
#+END_SRC #+END_SRC

2
src/backend/modern-tests.lisp
View File

@@ -72,7 +72,7 @@
(test osc8-escape (test osc8-escape
"OSC 8 hyperlink escape wraps text" "OSC 8 hyperlink escape wraps text"
(is (equal (cl-tty.backend::osc8-link "http://example.com" "click here") (is (equal (cl-tty.backend::osc8-link "http://example.com" "click here")
(format nil "~C]8;;http://example.com~C\\click here~C]8;;~C\" (format nil "~C]8;;http://example.com~C\click here~C]8;;~C\"
#\Esc #\Esc #\Esc #\Esc)))) #\Esc #\Esc #\Esc #\Esc))))
(test hex-color-parsing (test hex-color-parsing

2
src/backend/modern.lisp
View File

@@ -90,7 +90,7 @@ as a fallback when a keyword is not in *named-colors*.")
(defun osc8-link (url text) (defun osc8-link (url text)
"Wrap TEXT in an OSC 8 hyperlink to URL." "Wrap TEXT in an OSC 8 hyperlink to URL."
(format nil "~C]8;;~A~C\\~A~C]8;;~C\\" (format nil \"~C]8;;~A~C\\~A~C]8;;~C\\\"
#\Esc url #\Esc text #\Esc #\Esc)) #\Esc url #\Esc text #\Esc #\Esc))
(defparameter *border-chars* (defparameter *border-chars*