Amr Gharbeia
c227877302
Bug fixes: - Fix box() calls: set color-pair before box, pass ACS default chtype integers - Fix markdown functions: move to passepartout.channel-tui package where Croatoan is imported; use add-attributes/remove-attributes instead of :bold/:underline kwargs to add-string; call theme-color in gate-trace-lines to convert theme keys to Croatoan colors - Fix sandbox: remove dex:get/dex:post from restricted symbols (blocked neuro-provider from loading) - Export *log-lock* from passepartout (was unbound in jailed skill packages) - Fix configure: always deploy to XDG, skip cp when source==dest - Fix bash crash handler format string (~~ escaping) - Revert test reorder in 28 files (caused package leakage in skill loader) Design cleanup: - Extract tui-run-screen from tui-main for clean separation - Remove inject-stimulus alias - Merge *backend-registry* into *probabilistic-backends* - Fix read-framed-message whitespace DoS (4096-iteration max) - Add *read-eval* nil to dispatcher-approvals-process read-from-string
88 lines
3.1 KiB
Org Mode
88 lines
3.1 KiB
Org Mode
#+TITLE: SKILL: Protocol Validator (org-skill-protocol-validator.org)
|
|
#+AUTHOR: Agent
|
|
#+FILETAGS: :system:protocol:validation:
|
|
#+PROPERTY: header-args:lisp :tangle ../lisp/security-validator.lisp
|
|
|
|
* Overview
|
|
The Protocol Validator enforces schema compliance on every message entering or leaving the cognitive pipeline. It checks that messages are valid plists, that they have the required ~:type~ and ~:payload~ fields, and that the type is one of the known types (~:REQUEST~, ~:EVENT~, ~:RESPONSE~, ~:LOG~, ~:STATUS~). This prevents malformed messages from crashing the pipeline and ensures backward compatibility when the protocol evolves.
|
|
|
|
* Architectural Intent
|
|
|
|
The Protocol Validator wraps ~validate-communication-protocol-schema~
|
|
(the core communication function) in a skill-level gate. It is the first
|
|
filter every message passes through — malformed messages are rejected
|
|
before they reach any cognitive stage.
|
|
|
|
** Contract
|
|
|
|
1. (validator-protocol-check msg): returns ~msg~ if valid per
|
|
~validate-communication-protocol-schema~. Signals ~error~ on
|
|
malformed messages (caught by the skill's deterministic gate).
|
|
2. The skill's deterministic gate wraps the validator: valid actions pass
|
|
through; invalid actions produce a ~:LOG~ rejection with
|
|
~:level :error~.
|
|
|
|
** Boundaries
|
|
|
|
- Does NOT define the schema — that is ~core-transport.org~.
|
|
- Does NOT validate semantic content — that is the Dispatcher and Policy.
|
|
|
|
* Implementation
|
|
|
|
** Package Context
|
|
#+begin_src lisp
|
|
(in-package :passepartout)
|
|
#+end_src
|
|
|
|
** Validation Logic
|
|
;; REPL-VERIFIED: 2026-05-03T13:00:00
|
|
#+begin_src lisp
|
|
(defun validator-protocol-check (msg)
|
|
"Enforces structural schema compliance on protocol messages."
|
|
(validate-communication-protocol-schema msg))
|
|
#+end_src
|
|
|
|
** Skill Registration
|
|
#+begin_src lisp
|
|
(defskill :passepartout-security-validator
|
|
:priority 95
|
|
:trigger (lambda (ctx) (declare (ignore ctx)) t)
|
|
:deterministic (lambda (action ctx)
|
|
(declare (ignore ctx))
|
|
(handler-case
|
|
(progn (validator-protocol-check action) action)
|
|
(error (c)
|
|
(list :type :LOG :payload (list :level :error :text (format nil "Protocol Violation: ~a" c)))))))
|
|
#+end_src
|
|
|
|
* Test Suite
|
|
|
|
#+begin_src lisp
|
|
(eval-when (:compile-toplevel :load-toplevel :execute)
|
|
(ql:quickload :fiveam :silent t))
|
|
|
|
(defpackage :passepartout-security-validator-tests
|
|
(:use :cl :fiveam :passepartout)
|
|
(:export #:validator-suite))
|
|
|
|
(in-package :passepartout-security-validator-tests)
|
|
|
|
(def-suite validator-suite :description "Verification of the Protocol Validator")
|
|
(in-suite validator-suite)
|
|
|
|
(test test-validator-passes-valid-message
|
|
"Contract 1: a valid message passes protocol check."
|
|
(let ((msg '(:type :EVENT :payload (:sensor :heartbeat))))
|
|
(handler-case
|
|
(progn
|
|
(validator-protocol-check msg)
|
|
(pass))
|
|
(error (c)
|
|
(fail "Validator rejected a valid message: ~a" c)))))
|
|
|
|
(test test-validator-rejects-missing-type
|
|
"Contract 1: a message missing :type is rejected."
|
|
(let ((msg '(:payload (:sensor :heartbeat))))
|
|
(signals error
|
|
(validator-protocol-check msg))))
|
|
#+end_src |