370 lines
18 KiB
Org Mode
370 lines
18 KiB
Org Mode
#+TITLE: The Skill Engine (skills.lisp)
|
|
#+AUTHOR: Amr
|
|
#+FILETAGS: :kernel:skills:
|
|
#+STARTUP: content
|
|
|
|
* The Skill Engine (skills.lisp)
|
|
** Deep Reasoning: Late-Binding Intelligence
|
|
Hardcoding logic into a compiled binary creates a "Brittle Kernel."
|
|
- **Institutional Memory:** By using Literate Org files as skills, the "Why" (PRD) and the "How" (Lisp) are unified.
|
|
- **Hot-Reloading:** The agent can "learn" a new trick (recompile a package) while running. This allows for a continuous evolutionary loop where the agent can eventually rewrite its own skills to fix bugs it perceives.
|
|
|
|
** Package Context
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(in-package :org-agent)
|
|
#+end_src
|
|
|
|
** Skill Definition (defstruct skill)
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defstruct skill name priority dependencies trigger-fn neuro-prompt symbolic-fn)
|
|
#+end_src
|
|
|
|
** Skill Catalog Tracking
|
|
A stateful tracking table for all skill files discovered in the environment.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defvar *skill-catalog* (make-hash-table :test 'equal)
|
|
"A stateful tracking table for all skill files discovered in the environment.")
|
|
#+end_src
|
|
|
|
** Skill Entry Structure
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defstruct skill-entry
|
|
filename
|
|
(status :discovered) ;; :discovered, :loading, :ready, :failed
|
|
error-log
|
|
(load-time 0))
|
|
#+end_src
|
|
|
|
** Skill Selection (find-triggered-skill)
|
|
Iterates through the registry to find the highest-priority skill whose trigger function matches the current context.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun find-triggered-skill (context)
|
|
"Returns the highest priority skill whose trigger condition matches the context."
|
|
(let ((triggered nil))
|
|
(maphash (lambda (name skill)
|
|
(declare (ignore name))
|
|
(when (ignore-errors (funcall (skill-trigger-fn skill) context))
|
|
(push skill triggered)))
|
|
*skills-registry*)
|
|
(first (sort triggered #'> :key #'skill-priority))))
|
|
#+end_src
|
|
|
|
** Skill Definition Macro (defskill)
|
|
The primary macro used within Org files to register new agent capabilities.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defmacro defskill (name &key priority dependencies trigger neuro symbolic)
|
|
"Registers a new skill into the global registry."
|
|
`(setf (gethash (string-downcase (string ,name)) *skills-registry*)
|
|
(make-skill :name (string-downcase (string ,name))
|
|
:priority (or ,priority 10)
|
|
:dependencies ',dependencies
|
|
:trigger-fn ,trigger
|
|
:neuro-prompt ,neuro
|
|
:symbolic-fn ,symbolic)))
|
|
#+end_src
|
|
|
|
** Dependency Resolution (resolve-skill-dependencies)
|
|
Ensures that skills are loaded and unloaded in the correct order.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun resolve-skill-dependencies (skill-name)
|
|
"Recursively resolves dependencies for a given skill name."
|
|
(let ((resolved nil) (seen nil))
|
|
(labels ((visit (name)
|
|
(unless (member name seen :test #'equal)
|
|
(push name seen)
|
|
(let ((skill (gethash (string-downcase (string name)) *skills-registry*)))
|
|
(when skill
|
|
(dolist (dep (skill-dependencies skill))
|
|
(visit dep))))
|
|
(push name resolved))))
|
|
(visit skill-name)
|
|
(nreverse resolved))))
|
|
#+end_src
|
|
|
|
** Metadata Parsing (parse-skill-metadata)
|
|
Robustly extracts `#+DEPENDS_ON:` and `:ID:` tags from an Org file without full AST parsing.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun parse-skill-metadata (filepath)
|
|
"Extracts ID and DEPENDS_ON tags using robust line-scanning."
|
|
(let ((dependencies nil)
|
|
(id nil))
|
|
(with-open-file (stream filepath)
|
|
(loop for line = (read-line stream nil :eof)
|
|
until (eq line :eof)
|
|
do (let ((clean (string-trim '(#\Space #\Tab #\Return #\Newline) line)))
|
|
(cond
|
|
((uiop:string-prefix-p "#+DEPENDS_ON:" (string-upcase clean))
|
|
(let* ((deps-part (string-trim " " (subseq clean 13))))
|
|
(setf dependencies (append dependencies
|
|
(mapcar (lambda (s) (string-trim "[] " s))
|
|
(uiop:split-string deps-part :separator '(#\Space #\Tab)))))))
|
|
((uiop:string-prefix-p ":ID:" (string-upcase clean))
|
|
(setf id (string-trim '(#\Space #\Tab) (subseq clean 4))))))))
|
|
(values id (remove-if (lambda (s) (= 0 (length s))) dependencies))))
|
|
#+end_src
|
|
|
|
** Topological Sorting (topological-sort-skills)
|
|
Calculates the correct load order for a directory of skill filepaths, detecting circular dependencies.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun topological-sort-skills (skills-dir)
|
|
"Returns a list of skill filepaths sorted by dependency (dependencies first)."
|
|
(let ((files (uiop:directory-files skills-dir "org-skill-*.org"))
|
|
(adj (make-hash-table :test 'equal))
|
|
(id-to-file (make-hash-table :test 'equal))
|
|
(result nil)
|
|
(visited (make-hash-table :test 'equal))
|
|
(stack (make-hash-table :test 'equal)))
|
|
(dolist (file files)
|
|
(let ((filename (pathname-name file)))
|
|
(multiple-value-bind (id deps) (parse-skill-metadata file)
|
|
(setf (gethash (string-downcase filename) id-to-file) file)
|
|
(when id (setf (gethash (string-downcase id) id-to-file) file))
|
|
(setf (gethash (string-downcase filename) adj) deps))))
|
|
(labels ((visit (file)
|
|
(let* ((filename (pathname-name file))
|
|
(node-key (string-downcase filename)))
|
|
(unless (gethash node-key visited)
|
|
(setf (gethash node-key stack) t)
|
|
(dolist (dep (gethash node-key adj))
|
|
(let* ((dep-id (if (and (> (length dep) 3) (uiop:string-prefix-p "id:" (string-downcase dep)))
|
|
(subseq dep 3)
|
|
dep))
|
|
(dep-file (gethash (string-downcase dep-id) id-to-file)))
|
|
(when dep-file
|
|
(let ((dep-filename (pathname-name dep-file)))
|
|
(if (gethash (string-downcase dep-filename) stack)
|
|
(error "Circular dependency detected: ~a -> ~a" filename dep-filename)
|
|
(visit dep-file))))))
|
|
(setf (gethash node-key stack) nil)
|
|
(setf (gethash node-key visited) t)
|
|
(push file result)))))
|
|
(let ((filenames (sort (mapcar #'pathname-name files) #'string<)))
|
|
(dolist (name filenames)
|
|
(let ((file (gethash (string-downcase name) id-to-file)))
|
|
(when file (visit file)))))
|
|
result)))
|
|
#+end_src
|
|
|
|
** Syntax Validation (validate-lisp-syntax)
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun validate-lisp-syntax (code-string)
|
|
"Checks if a string contains valid, readable Common Lisp forms."
|
|
(handler-case
|
|
(let ((*read-eval* nil))
|
|
(with-input-from-string (stream (format nil "(progn ~a)" code-string))
|
|
(loop for form = (read stream nil :eof) until (eq form :eof))
|
|
(values t nil)))
|
|
(error (c) (values nil (format nil "~a" c)))))
|
|
#+end_src
|
|
|
|
** Jailed Loading (load-skill-from-org)
|
|
The core "hot-loading" mechanism. It extracts Lisp blocks from an Org file and evaluates them within a dedicated package ("Jail").
|
|
|
|
*** Phase A: Demand
|
|
- *Need:* Safely load skills from `.org` files without evaluating docstrings or kernel-level tangled blocks as logic.
|
|
- *Success:* Exclude `#+begin_src lisp :tangle` blocks and ignore `:PROPERTIES:` and `:END:` drawers embedded within src blocks.
|
|
|
|
*** Phase B: Blueprint
|
|
The loader must actively scan block arguments and filter out those containing `:tangle`. It also needs to cleanly skip Org properties that Emacs might auto-generate inside src blocks.
|
|
|
|
*** Phase D: Build
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun load-skill-from-org (filepath)
|
|
"Parses and evaluates Lisp blocks from an Org file into a jailed package."
|
|
(let* ((skill-base-name (pathname-name filepath))
|
|
(entry (or (gethash skill-base-name *skill-catalog*) (make-skill-entry :filename skill-base-name))))
|
|
(setf (skill-entry-status entry) :loading)
|
|
(setf (gethash skill-base-name *skill-catalog*) entry)
|
|
|
|
(handler-case
|
|
(let* ((content (uiop:read-file-string filepath))
|
|
(lines (uiop:split-string content :separator '(#\Newline)))
|
|
(in-lisp-block nil)
|
|
(lisp-code "")
|
|
(pkg-name (intern (string-upcase (format nil "ORG-AGENT.SKILLS.~a" skill-base-name)) :keyword)))
|
|
|
|
(dolist (line lines)
|
|
(let ((clean-line (string-trim '(#\Space #\Tab #\Return) line)))
|
|
(cond ((uiop:string-prefix-p "#+begin_src lisp" (string-downcase clean-line))
|
|
;; Only load blocks that are NOT tangled to src/ or elsewhere
|
|
(if (search ":tangle" (string-downcase clean-line))
|
|
(setf in-lisp-block nil)
|
|
(setf in-lisp-block t)))
|
|
((uiop:string-prefix-p "#+end_src" (string-downcase clean-line))
|
|
(setf in-lisp-block nil))
|
|
(in-lisp-block
|
|
(unless (or (uiop:string-prefix-p ":PROPERTIES:" (string-upcase clean-line))
|
|
(uiop:string-prefix-p ":END:" (string-upcase clean-line)))
|
|
(setf lisp-code (concatenate 'string lisp-code line (string #\Newline))))))))
|
|
|
|
(if (= (length lisp-code) 0)
|
|
(progn (setf (skill-entry-status entry) :ready) t) ;; Valid empty skill
|
|
(progn
|
|
;; PRE-FLIGHT: Syntax Validation
|
|
(multiple-value-bind (valid-p err) (validate-lisp-syntax lisp-code)
|
|
(unless valid-p
|
|
(error "Syntax Error: ~a" err)))
|
|
|
|
(kernel-log "KERNEL: Jailing skill '~a' in package ~a" skill-base-name pkg-name)
|
|
(unless (find-package pkg-name)
|
|
(let ((new-pkg (make-package pkg-name :use '(:cl))))
|
|
(do-external-symbols (sym (find-package :org-agent)) (shadowing-import sym new-pkg))))
|
|
|
|
(let ((*read-eval* nil) (*package* (find-package pkg-name)))
|
|
(eval (read-from-string (format nil "(progn ~a)" lisp-code))))
|
|
|
|
(setf (skill-entry-status entry) :ready)
|
|
t)))
|
|
(error (c)
|
|
(let ((msg (format nil "~a" c)))
|
|
(kernel-log "LOADER ERROR in skill '~a': ~a" skill-base-name msg)
|
|
(setf (skill-entry-status entry) :failed)
|
|
(setf (skill-entry-error-log entry) msg)
|
|
nil)))))
|
|
#+end_src
|
|
|
|
** Safe Loading with Timeout (load-skill-with-timeout)
|
|
Wraps the skill loader in a thread with a hard timeout to prevent a single malformed skill from hanging the entire kernel boot sequence.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun load-skill-with-timeout (filepath timeout-seconds)
|
|
"Loads a skill Org file with a hard execution timeout."
|
|
(let* ((finished nil)
|
|
(thread (bt:make-thread (lambda ()
|
|
(if (load-skill-from-org filepath)
|
|
(setf finished t)
|
|
(setf finished :error)))
|
|
:name (format nil "loader-~a" (pathname-name filepath))))
|
|
(start-time (get-internal-real-time))
|
|
(timeout-units (truncate (* timeout-seconds internal-time-units-per-second))))
|
|
(loop
|
|
(when (eq finished t) (return :success))
|
|
(when (eq finished :error) (return :error))
|
|
(unless (bt:thread-alive-p thread) (return :error))
|
|
(when (> (- (get-internal-real-time) start-time) timeout-units)
|
|
(kernel-log "KERNEL: Timing out skill ~a..." (pathname-name filepath))
|
|
#+sbcl (sb-thread:terminate-thread thread)
|
|
#-sbcl (bt:destroy-thread thread)
|
|
(return :timeout))
|
|
(sleep 0.05))))
|
|
#+end_src
|
|
|
|
** Initializing All Skills (initialize-all-skills)
|
|
The unified orchestrator for the kernel boot sequence. It scans the environment, calculates dependencies, and loads the system brain.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun initialize-all-skills ()
|
|
"Scans the directory defined by SKILLS_DIR and hot-loads skills using topological order."
|
|
(let* ((env-path (uiop:getenv "SKILLS_DIR"))
|
|
(skills-dir-str (or env-path (namestring (merge-pathnames "notes/" (user-homedir-pathname)))))
|
|
(resolved-path (context-resolve-path skills-dir-str))
|
|
(skills-dir (if resolved-path (uiop:ensure-directory-pathname resolved-path) nil)))
|
|
|
|
(unless (and skills-dir (uiop:directory-exists-p skills-dir))
|
|
(kernel-log "KERNEL ERROR: Skills directory not found: ~a" skills-dir-str)
|
|
(return-from initialize-all-skills nil))
|
|
|
|
(let ((sorted-files (topological-sort-skills skills-dir)))
|
|
;; MANDATE: The Executive Soul must be present
|
|
(unless (member "org-skill-agent" sorted-files :key #'pathname-name :test #'string-equal)
|
|
(error "BOOT FAILURE: org-skill-agent.org not found in skills directory."))
|
|
|
|
(kernel-log "==================================================")
|
|
(kernel-log " LOADER: Initializing ~a skills..." (length sorted-files))
|
|
|
|
(dolist (file sorted-files)
|
|
(let ((skill-name (pathname-name file)))
|
|
(kernel-log " LOADER: Loading ~a..." skill-name)
|
|
(load-skill-with-timeout file 5)))
|
|
|
|
;; Final Summary
|
|
(let ((ready 0) (failed 0))
|
|
(maphash (lambda (k v)
|
|
(declare (ignore k))
|
|
(if (eq (skill-entry-status v) :ready) (incf ready) (incf failed)))
|
|
*skill-catalog*)
|
|
(kernel-log " LOADER: Boot Complete. [Ready: ~a] [Failed: ~a]" ready failed)
|
|
(kernel-log "==================================================")
|
|
(values ready failed)))))
|
|
#+end_src
|
|
|
|
** Toolbelt Prompt Generation (generate-tool-belt-prompt)
|
|
Constructs the technical documentation of available tools that is injected into the LLM system prompt.
|
|
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(defun generate-tool-belt-prompt ()
|
|
"Aggregates all registered cognitive tools into a descriptive prompt."
|
|
(let ((output (format nil "AVAILABLE TOOLS:
|
|
You can call tools by returning a Lisp plist: (:target :tool :action :call :tool <name> :args (...))
|
|
|
|
EXAMPLES:
|
|
(:target :tool :action :call :tool \"eval\" :args (:code \"(+ 1 1)\"))
|
|
(:target :tool :action :call :tool \"grep-search\" :args (:pattern \"sovereignty\"))
|
|
(:target :tool :action :call :tool \"shell\" :args (:cmd \"ls -la\"))
|
|
|
|
---
|
|
")))
|
|
(maphash (lambda (name tool)
|
|
(setf output (concatenate 'string output
|
|
(format nil "- ~a: ~a~% Parameters: ~s~%~%"
|
|
name
|
|
(cognitive-tool-description tool)
|
|
(cognitive-tool-parameters tool)))))
|
|
*cognitive-tools*)
|
|
output))
|
|
#+end_src
|
|
|
|
** The Default Tool Belt
|
|
We register a set of standard cognitive tools that all skills can use.
|
|
|
|
*** The Eval Tool
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(def-cognitive-tool :eval "Evaluates raw Common Lisp code in the kernel image. Use this for complex calculations or internal state inspection."
|
|
((:code :type :string :description "The Lisp code to evaluate"))
|
|
:guard (lambda (args context)
|
|
(declare (ignore context))
|
|
(let ((code (getf args :code)))
|
|
(let ((harness-pkg (find-package :org-agent.skills.org-skill-safety-harness)))
|
|
(if harness-pkg
|
|
(uiop:symbol-call :org-agent.skills.org-skill-safety-harness :safety-harness-validate code)
|
|
t))))
|
|
:body (lambda (args)
|
|
(let ((code (getf args :code)))
|
|
(handler-case (let ((result (eval (read-from-string code))))
|
|
(format nil "~s" result))
|
|
(error (c) (format nil "ERROR: ~a" c))))))
|
|
#+end_src
|
|
|
|
*** The Grep Tool
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(def-cognitive-tool :grep-search "Searches for a pattern in the project files."
|
|
((:pattern :type :string :description "The regex pattern to search for")
|
|
(:dir :type :string :description "Directory to search in (default is project root)"))
|
|
:body (lambda (args)
|
|
(let ((pattern (getf args :pattern))
|
|
(dir (or (getf args :dir) (uiop:getenv "MEMEX_DIR"))))
|
|
(uiop:run-program (list "grep" "-r" "-n" "--exclude-dir=node_modules" pattern dir)
|
|
:output :string :ignore-error-status t))))
|
|
#+end_src
|
|
|
|
*** The Shell Tool
|
|
#+begin_src lisp :tangle ../src/skills.lisp
|
|
(def-cognitive-tool :shell "Executes a shell command on the local machine. Use this for file operations, system checks, or running tests."
|
|
((:cmd :type :string :description "The full bash command to execute"))
|
|
:guard (lambda (args context)
|
|
(declare (ignore context))
|
|
(let ((cmd (getf args :cmd)))
|
|
(not (or (search "rm -rf /" cmd) (search ":(){ :|:& };:" cmd)))))
|
|
:body (lambda (args)
|
|
(let ((cmd (getf args :cmd)))
|
|
(multiple-value-bind (out err code)
|
|
(uiop:run-program (list "bash" "-c" cmd) :output :string :error-output :string :ignore-error-status t)
|
|
(format nil "EXIT-CODE: ~a~%~%STDOUT:~%~a~%~%STDERR:~%~a" code out err)))))
|
|
#+end_src
|