review fixes: version bump, keyword check, warning assertion
Fixes from subagent review: - ASDF version 0.3.0 → 0.4.0 - define-preset now checks (check-type name keyword) at macro-expand time - load-preset-unknown-warns test now uses (signals warning ...) to actually verify the warning fires (was false-positive before)
This commit is contained in:
@@ -2,7 +2,7 @@
|
||||
(asdf:defsystem :cl-tui
|
||||
:description "Reusable Common Lisp Terminal UI Framework"
|
||||
:author "Amr Gharbeia"
|
||||
:version "0.3.0"
|
||||
:version "0.4.0"
|
||||
:license "TBD"
|
||||
:depends-on (:fiveam)
|
||||
:components
|
||||
|
||||
@@ -48,7 +48,7 @@
|
||||
(test load-preset-unknown-warns
|
||||
"Unknown preset warns but doesn't error"
|
||||
(let ((th (make-theme)))
|
||||
(load-preset th :nonexistent)
|
||||
(signals warning (load-preset th :nonexistent))
|
||||
(is (null (theme-color th :primary)))))
|
||||
|
||||
(test preset-switch-mode
|
||||
|
||||
@@ -22,6 +22,7 @@
|
||||
(defmacro define-preset (name &key dark light)
|
||||
"Define a theme preset with DARK and LIGHT variants.
|
||||
NAME should be a keyword (e.g., :default, :nord)."
|
||||
(check-type name keyword)
|
||||
`(setf (gethash ,name *presets*) '(:dark ,dark :light ,light)))
|
||||
|
||||
(defun load-preset (theme preset-name)
|
||||
|
||||
Reference in New Issue
Block a user